[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525329#comment-16525329
 ] 

Christine Poerschke commented on ZOOKEEPER-3061:
------------------------------------------------

Thanks [~maoling] for the question on my initial patch!
{quote}... and we can use sid to associate them ...
{quote}
Yes, once one knows that the {{"Synchronizing with Follower sid: ..."}} INFO 
logging mostly contains the meaning behind the {{"Unhandled scenario"}} WARN 
phrase then a repeat of the details is not strictly necessary.

Including the extra details in the warning is aimed at users who have not yet 
associated the two log lines, plus I'm suggesting for the warning to also log 
the {{txnLogSyncEnabled}} variable which is used in the handling logic but not 
logged by the adjacent INFO log line.

> add more details to 'Unhandled scenario for peer' log.warn message
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3061
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
>             Project: ZooKeeper
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}} 
> logging already contains most relevant details but it would be convenient to 
> more directly have full details in the {{LOG.warn("Unhandled scenario for 
> peer sid: ...}} itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to