Hi Pat, Yes please hold off reviewing. A quick look indicates that this RC is problematic in terms of the C client build files - I don't know what happened as I was following standard release protocol. I'll investigate a little bit more, and cut a new RC before next Monday.
On Wed, Jun 27, 2018 at 12:30 PM, Patrick Hunt <ph...@apache.org> wrote: > Given this has a -1 should I hold off reviewing? Michael what are you > planning to do? Cut another RC? > > Patrick > > On Wed, Jun 27, 2018 at 7:17 AM Norbert Kalmar > <nkal...@cloudera.com.invalid> wrote: > >> +1 (non-binding) >> >> Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of >> 3, runed basic commands (create, get,set, delete etc.). >> MacOS 10.13.4 >> >> Thanks, >> Norbert >> >> On Wed, Jun 27, 2018 at 3:45 PM Andor Molnar <an...@cloudera.com.invalid> >> wrote: >> >> > + tested with different cluster sizes: 1,3,5,7 >> > + verified a few 4lw commands >> > + verified JMX interface >> > >> > Regards, >> > Andor >> > >> > >> > On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar <an...@cloudera.com> >> wrote: >> > >> > > Hi Michael, >> > > >> > > Thanks for putting together this new release. >> > > >> > > My vote: -1 >> > > >> > > I've run the following tests so far: >> > > + signatures verified >> > > + java unit tests successful >> > > - unable to build C client / C++ unit tests, because ./configure >> script >> > is >> > > not executable >> > > >> > > BUILD FAILED >> > > /home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error >> > > occurred while executing this line: >> > > /home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error >> > > occurred while executing this line: >> > > /home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed: >> > > java.io.IOException: Cannot run program >> > "/home/andor/work/zookeeper-3.4.13/src/c/configure" >> > > (in directory >> > "/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"): >> > > error=13, Permission denied >> > > >> > > Looking at the contents of the C client, it's slightly different from >> > what >> > > we released in 3.4.12: >> > > >> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c >> > > total 1748 >> > > -rw-rw-r--. 1 andor andor 11533 Mar 27 06:32 acinclude.m4 >> > > -rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4 >> > > -rw-rw-r--. 1 andor andor 4733 Mar 27 06:32 aminclude.am >> > > drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache >> > > -rw-rw-r--. 1 andor andor 50794 Mar 27 06:32 c-doc.Doxyfile >> > > -rw-rw-r--. 1 andor andor 4343 Mar 27 06:32 ChangeLog >> > > -rw-rw-r--. 1 andor andor 4763 Mar 27 06:32 cmake_config.h.in >> > > -rw-rw-r--. 1 andor andor 6456 Mar 27 06:32 CMakeLists.txt >> > > -rwxr-xr-x. 1 andor andor 7333 Mar 27 06:32 compile >> > > -rwxr-xr-x. 1 andor andor 43499 Mar 27 06:32 config.guess >> > > -rw-rw-r--. 1 andor andor 3989 Mar 27 06:32 config.h.in >> > > -rwxr-xr-x. 1 andor andor 36144 Mar 27 06:32 config.sub >> > > -rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure >> > > -rw-rw-r--. 1 andor andor 4110 Mar 27 06:32 configure.ac >> > > -rwxr-xr-x. 1 andor andor 23566 Mar 27 06:32 depcomp >> > > drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated >> > > drwxr-xr-x. 2 andor andor 127 Mar 27 06:32 include >> > > -rw-rw-r--. 1 andor andor 9416 Mar 27 06:32 INSTALL >> > > -rwxr-xr-x. 1 andor andor 15155 Mar 27 06:32 install-sh >> > > -rw-rw-r--. 1 andor andor 11358 Mar 27 06:32 LICENSE >> > > -rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh >> > > -rw-rw-r--. 1 andor andor 4367 Mar 27 06:32 Makefile.am >> > > -rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in >> > > -rwxr-xr-x. 1 andor andor 6872 Mar 27 06:32 missing >> > > -rw-rw-r--. 1 andor andor 1961 Mar 27 06:32 NOTICE.txt >> > > -rw-rw-r--. 1 andor andor 7400 Mar 27 06:32 README >> > > drwxr-xr-x. 3 andor andor 245 Mar 27 06:32 src >> > > drwxr-xr-x. 2 andor andor 4096 Mar 27 06:32 tests >> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c >> > > total 1468 >> > > -rw-r--r--. 1 andor andor 11533 Jun 22 20:03 acinclude.m4 >> > > -rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4 >> > > -rw-r--r--. 1 andor andor 4733 Jun 22 20:03 aminclude.am >> > > drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache >> > > -rw-r--r--. 1 andor andor 50794 Jun 22 20:03 c-doc.Doxyfile >> > > -rw-r--r--. 1 andor andor 4343 Jun 22 20:03 ChangeLog >> > > -rw-r--r--. 1 andor andor 4763 Jun 22 20:03 cmake_config.h.in >> > > -rw-r--r--. 1 andor andor 6456 Jun 22 20:03 CMakeLists.txt >> > > -rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure >> > > -rw-r--r--. 1 andor andor 4423 Jun 22 20:03 configure.ac >> > > drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated >> > > drwxr-xr-x. 2 andor andor 127 Jun 27 13:12 include >> > > -rw-r--r--. 1 andor andor 9416 Jun 22 20:03 INSTALL >> > > -rw-r--r--. 1 andor andor 11358 Jun 22 20:03 LICENSE >> > > -rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh >> > > -rw-r--r--. 1 andor andor 4509 Jun 22 20:03 Makefile.am >> > > -rw-r--r--. 1 andor andor 1961 Jun 22 20:03 NOTICE.txt >> > > -rw-r--r--. 1 andor andor 7400 Jun 22 20:03 README >> > > drwxr-xr-x. 3 andor andor 245 Jun 22 20:03 src >> > > drwxr-xr-x. 2 andor andor 4096 Jun 27 13:12 tests >> > > >> > > Some of the files are missing, others don't have executable bit. >> > > Do you have an idea what could go wrong? >> > > >> > > I continue testing with cluster setups. >> > > >> > > Regards, >> > > Andor >> > > >> > > >> > > >> > > >> > > >> > > >> > > On Sat, Jun 23, 2018 at 12:31 AM, Michael Han <h...@apache.org> >> wrote: >> > > >> > >> This is a bugfix release candidate for 3.4.13. It fixes 17 issues, >> > >> including issues such as ZOOKEEPER-2959 >> > >> <https://issues.apache.org/jira/browse/ZOOKEEPER-2959> that could >> cause >> > >> data loss when observer is used, and ZOOKEEPER-2184 >> > >> <https://issues.apache.org/jira/browse/ZOOKEEPER-2184> that prevents >> > >> ZooKeeper Java clients working in dynamic IP (container / cloud) >> > >> environment. >> > >> >> > >> The full release notes is available at: >> > >> >> > >> *https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >> > >> ectId=12310801&version=12342973 >> > >> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >> > >> ectId=12310801&version=12342973>* >> > >> >> > >> *** Please download, test and vote by June 27th 2018, 23:59 UTC+0. >> *** >> > >> >> > >> Source files: >> > >> http://people.apache.org/~hanm/zookeeper/zookeeper-3.4.13-rc0/ >> > >> >> > >> Maven staging repo: >> > >> https://repository.apache.org/content/groups/staging/org/apa >> > >> che/zookeeper/zookeeper/3.4.13/ >> > >> >> > >> The release candidate tag in git to be voted upon: release-3.4.13-rc0 >> > >> >> > >> ZooKeeper's KEYS file containing PGP keys we use to sign the release: >> > >> http://www.apache.org/dist/zookeeper/KEYS >> > >> >> > >> Should we release this candidate? >> > >> >> > >> >> > >> Cheers >> > >> Michael >> > >> >> > > >> > > >> > >> >
