Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/556#discussion_r199726257
--- Diff: src/java/test/org/apache/zookeeper/server/ServerStatsTest.java ---
@@ -73,11 +73,11 @@ public void testLatencyMetrics() {
// Then ...
assertThat("Max latency check", 2000L,
- greaterThanOrEqualTo(serverStats.getMaxLatency()));
+ lessThanOrEqualTo(serverStats.getMaxLatency()));
--- End diff --
Thanks for catching this and fixing it! The serverstats.getMaxLatency()
should of went in the "actual" parameter and the magic number as the
greaterThanOrEqualTo parameter. (I did this test. Sorry...)
But changing greater to less work just fine.
---
