[
https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534038#comment-16534038
]
Hadoop QA commented on ZOOKEEPER-3082:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1896//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1896//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1896//console
This message is automatically generated.
> Fix server snapshot behavior when out of disk space
> ---------------------------------------------------
>
> Key: ZOOKEEPER-3082
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3082
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.6.0, 3.4.12, 3.5.5
> Reporter: Brian Nixon
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the ZK server tries to make a snapshot and the machine is out of disk
> space, the snapshot creation fails and throws an IOException. An empty
> snapshot file is created, (probably because the server is able to create an
> entry in the dir) but is not able to write to the file.
>
> If snapshot creation fails, the server commits suicide. When it restarts, it
> will do so from the last known good snapshot. However, when it tries to make
> a snapshot again, the same thing happens. This results in lots of empty
> snapshot files being created. If eventually the DataDirCleanupManager garbage
> collects the good snapshot files then only the empty files remain. At this
> point, the server is well and truly screwed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
