[
https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540578#comment-16540578
]
Hadoop QA commented on ZOOKEEPER-3062:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1926//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1926//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1926//console
This message is automatically generated.
> mention fsync.warningthresholdms in FileTxnLog LOG.warn message
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-3062
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3062
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Christine Poerschke
> Priority: Minor
> Labels: pull-request-available
> Attachments: ZOOKEEPER-3062.patch, ZOOKEEPER-3062.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The
> {code}
> fsync-ing the write ahead log in ... took ... ms which will adversely effect
> operation latency. File size is ... bytes. See the ZooKeeper troubleshooting
> guide
> {code}
> warning mentioning the {{fsync.warningthresholdms}} configurable property
> would make it easier to discover and also when interpreting historical vs.
> current logs or logs from different ensembles then differences in
> configuration would be easier to spot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
