[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546181#comment-16546181
 ] 

Hadoop QA commented on ZOOKEEPER-3085:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1949//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1949//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1949//console

This message is automatically generated.

> Define constant exit code and add documents
> -------------------------------------------
>
>                 Key: ZOOKEEPER-3085
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3085
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Fangmin Lv
>            Assignee: Norbert Kalmar
>            Priority: Minor
>              Labels: newbie, pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are various hard coded exit code in different places of ZooKeeper, 
> which makes it's harder to track. Also we need to add some documents to make 
> it easier to understand what happened when it's exited.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to