GitHub user sl4mmy opened a pull request:
https://github.com/apache/zookeeper/pull/575
Zookeeper 3093
I noticed that zerror(ZNOWATCHER) returns "unknown error" and when I went
to investigate why I realized that actually three new values were added to
ZOO_ERRORS enum without corresponding cases in zerror. While here, also take
the opportunity to shuffle the ordering of cases in zerror to match ZOO_ERRORS
in order to make it easier to visually compare the two in the future to see if
any values are missing cases (e.g. the fact that ZNEWCONFIGNOQUORUM and
ZRECONFIGINPROGRESS were added to the bottom of the switch made it harder to
see which all cases were missing).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sl4mmy/zookeeper zookeeper-3093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit 991af67bce399c1a02ea128ff86608970452bc1b
Author: Kent R. Spillner <kspillner@...>
Date: 2018-07-18T19:56:22Z
src/c/src/zookeeper.c: fix indent-o
Signed-off-by: Kent R. Spillner <[email protected]>
commit f3c7aadcee1c229a7959df26f306033f71e63284
Author: Kent R. Spillner <kspillner@...>
Date: 2018-07-18T19:59:40Z
src/c/src/zookeeper.c: reorder cases in zerror(int)
Reorder cases in zerror(int) to match order of ZOO_ERRORS enum. Makes it
easier visually compare the two to see if any cases are missing.
Signed-off-by: Kent R. Spillner <[email protected]>
commit 6e6c9ca1d117e4853f2fce1802192e98ceb48796
Author: Kent R. Spillner <kspillner@...>
Date: 2018-07-18T20:06:04Z
ZOOKEEPER-3093: sync zerror with ZOO_ERRORS enum
Add missing cases for newly added ZOO_ERRORS values ZNOWATCHER,
ZEPHEMERALONLOCALSESSION, and ZRECONFIGDISABLED.
Signed-off-by: Kent R. Spillner <[email protected]>
----
---
