Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/580
  
    Finally this happens, thanks for contributing the change back @jtuple . My 
quick comments inline.
    
    In addition, there are two things:
    * There is find bug warning. I believe it's the txn variable 
[here](https://github.com/jtuple/zookeeper/blob/e6935f8d99eace05d29c2d6659e68e8b90b9a633/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java#L110)
 that should be removed. I know that's not part of this patch, and i am not 
sure why it gets triggered here, but please remove it so we can get a clean 
find bug check.
    
    * The test `org.apache.zookeeper.server.admin.CommandsTest` is failing. 
Please investigate.


---

Reply via email to