[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

[hanm]

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/447#discussion_r205630231
  
    --- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 
---
    @@ -280,6 +275,11 @@ public synchronized boolean addSession(long id, int 
sessionTimeout) {
             return added;
         }
     
    +    public synchronized boolean commitSession(long id, int sessionTimeout) 
{
    +        sessionsWithTimeout.put(id, sessionTimeout);
    +        return true;
    --- End diff --
    
    Should we make this `void commitSession` given this always returns true?


---