Github user pravsingh commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r205904126 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -66,8 +67,8 @@ public SaslQuorumAuthLearner(boolean quorumRequireSasl, + "section '" + loginContext + "' could not be found."); } - this.learnerLogin = new Login(loginContext, - new SaslClientCallbackHandler(null, "QuorumLearner"), new ZKConfig()); + this.learnerLogin = loginFactory.createLogin(loginContext, + new SaslClientCallbackHandler(null, "QuorumLearner"), new ZKConfig()); --- End diff -- this can be put on above line. makes it more readable.
---