Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922808
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +275,11 @@ public synchronized boolean addSession(long id, int
sessionTimeout) {
return added;
}
+ public synchronized boolean commitSession(long id, int sessionTimeout)
{
+ sessionsWithTimeout.put(id, sessionTimeout);
+ return true;
--- End diff --
The LeaderSessionTracker.commitSession will return whether it has
successfully added the new session, but the return value is not being used
anywhere in the code currently.
I'll update this to reflect that as well.
---
