[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563613#comment-16563613
 ] 

maoling commented on ZOOKEEPER-3107:
------------------------------------

[~psinghiitr]

yes.when we have moved from Ant to Maven.we use Maven Checkstyle Plugin at the 
build time to generate QA report just like HBase.Since there are too many 
violates in the current code base.so we can make this issue an umbrella to 
clean up the violates one package by another

> Coding standard and Checkstyle
> ------------------------------
>
>                 Key: ZOOKEEPER-3107
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3107
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Praveendra Singh
>            Priority: Minor
>
> I'm new to the Zookeeper as a contributor.
> Was going through 
> [https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute] a and 
> noticed that link to [Sun's 
> conventions|http://www.oracle.com/technetwork/java/codeconv-138413.html] 
> doesn't work. Did some googling and noticed that it is archived at 
> [https://www.oracle.com/technetwork/java/javase/overview/codeconvtoc-136057.html].
>  
> Do we still use this coding standard?
> Apart from the code styling rules, we have additional ones listed on the 
> Contributor Guide.
> Instead of letting everyone remember all the rules, should we force it at 
> build time?
>  
> There is a [Maven Checkstyle 
> Plugin|https://maven.apache.org/plugins/maven-checkstyle-plugin/]  which can 
> be leveraged.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to