[ https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588546#comment-16588546 ]
Norbert Kalmar commented on ZOOKEEPER-1990: ------------------------------------------- Hi [~eribeiro], thanks for the update. Yes, it looks like we create a new Random instance every time anyway. The only thing that bothers mi a bit personally is why we use " new Random(System.nanoTime())" why not empty constructor instead, it is more random as it gets a different seed even if called at the same time. So this is the only thing I would change. Perheps also the session generation of new Random(sessionId ^ superSecret), in the comments, superSecret is supposed to be used only for password generation. > suspicious instantiation of java Random instances > ------------------------------------------------- > > Key: ZOOKEEPER-1990 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1990 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.5.0 > Reporter: Patrick Hunt > Assignee: Norbert Kalmar > Priority: Critical > Fix For: 3.6.0, 3.5.5 > > > It's not clear to me why we are doing this, but it looks very suspicious. Why > aren't we just calling "new Random()" in these cases? (even for the tests I > don't really see it - typically that would just be for repeatability) > {noformat} > ag "new Random[ \t]*\(" . > src/java/main/org/apache/zookeeper/ClientCnxn.java > 817: private Random r = new Random(System.nanoTime()); > src/java/main/org/apache/zookeeper/client/StaticHostProvider.java > 75: sourceOfRandomness = new Random(System.currentTimeMillis() ^ > this.hashCode()); > 98: sourceOfRandomness = new Random(randomnessSeed); > src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java > 420: rand = new Random(java.lang.Thread.currentThread().getId() > src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 64: private final Random r = new Random(System.nanoTime()); > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > 537: Random r = new Random(id ^ superSecret); > 554: Random r = new Random(sessionId ^ superSecret); > src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java > 271: Random r = new Random(SESSION_ID ^ superSecret); > src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 151: Random rand = new Random(Thread.currentThread().getId()); > 258: Random rand = new Random(Thread.currentThread().getId()); > 288: Random rand = new Random(Thread.currentThread().getId()); > src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java > 40: private Random r = new Random(1); > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)