Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212069968
--- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java ---
@@ -0,0 +1,63 @@
+package org.apache.zookeeper.server;
+
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketException;
+import java.io.IOException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SocketUtil {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SocketUtil.class);
+
+ public static final String NETWORK_BUFFER_SIZE =
"zookeeper.NetworkBufferSize";
+ protected static int networkBufferSize;
--- End diff --
Yes, I realized that, our internal code is using uppercase, but I agree we
should change it to keep consistent.
---
