[GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r212985974
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
    @@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config)
             LOG.info("Starting server");
             FileTxnSnapLog txnLog = null;
             try {
    +            try {
    +                metricsProvider = MetricsProviderBootstrap
    +                        
.startMetricsProvider(config.metricsProviderClassName, new Properties());
    +            } catch (MetricsProviderLifeCycleException error) {
    +                LOG.error("Cannot boot MetricsProvider {}", 
config.metricsProviderClassName, error);
    --- End diff --
    
    removed


---