Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/614#discussion_r214506993
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
    @@ -287,6 +288,9 @@ public static boolean waitForServerUp(String hp, long 
timeout, boolean secure) {
                             !result.contains("READ-ONLY")) {
                         return true;
                     }
    +            } catch (ConnectException e) {
    +                // ignore as this is expected, do not log stacktrace
    +                LOG.info("server {} not up", hp);
                 } catch (IOException e) {
    --- End diff --
    
    If printing the stacktraces is not very useful and annoying, Adding 
`e.getMessage()` just to tell us what type of exception has happened is better?


---

Reply via email to