[ https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602893#comment-16602893 ]
Hudson commented on ZOOKEEPER-3116: ----------------------------------- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #174 (See [https://builds.apache.org/job/ZooKeeper-trunk/174/]) ZOOKEEPER-3116: Make the DataTree.approximateDataSize more efficient (andor: rev 687ea7e7cecf1449687e05819502be28cb49cb66) * (edit) src/java/test/org/apache/zookeeper/server/DataTreeTest.java * (edit) src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java * (edit) src/java/main/org/apache/zookeeper/server/DataTreeBean.java * (edit) src/java/main/org/apache/zookeeper/server/DataNode.java * (edit) src/java/main/org/apache/zookeeper/server/admin/Commands.java * (edit) src/java/main/org/apache/zookeeper/server/DataTree.java > Make the DataTree.approximateDataSize more efficient > ---------------------------------------------------- > > Key: ZOOKEEPER-3116 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The approximateDataSize is a nice metric to show what's the total size stored > in ZooKeeper ensemble over time, but it's expensive to query too often, since > each query will go through all the nodes to calculate the total size. > It's better to use a counter to record the total data size when txns applied > to the DataTree, which is cheaper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)