[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606226#comment-16606226
]
Hadoop QA commented on ZOOKEEPER-3124:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 22 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2126//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2126//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2126//console
This message is automatically generated.
> Update the comment of special logic to handle cversion and pzxid in
> DataTree.processTxn
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3124
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3124
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> There is special logic in the DataTree.processTxn to handle the NODEEXISTS
> when createNode, which is used to handle the cversion and pzxid not being
> updated due to fuzzy snapshot:
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/DataTree.java#L962-L994.
>
> But is this a real issue, or is it still an issue for now?
> In the current code, when serializing a parent node, we'll lock on it, and
> take a children snapshot at that time. If the child added after the parent is
> serialized to disk, then it won't be written out, so we shouldn't hit the
> issue where the child is in the snapshot but parent cversion and pzxid is not
> changed.
>
>
> I checked the JIRA ZOOKEEPER-1269 which added this code, it won't hit this
> issue as well, I'm not sure why we added this, am I missing anything? Can we
> just get rid of it?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
