[
https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614332#comment-16614332
]
Hadoop QA commented on ZOOKEEPER-3108:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2166//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2166//console
This message is automatically generated.
> use a new property server.id in the zoo.cfg to substitute for myid file
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-3108
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3108
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: maoling
> Assignee: maoling
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When use zk in distributional model,we need to touch a myid file in
> dataDir.then write a unique number to it.It is inconvenient and not
> user-friendly,Look at an example from other distribution system such as
> kafka:it just uses broker.id=0 in the server.properties to indentify a unique
> server node.This issue is going to abandon the myid file and use a new
> property such as server.id=0 in the zoo.cfg. this fix will be applied to
> master branch,branch-3.5+,
> keep branch-3.4 unchaged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)