Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r218676806
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -819,7 +819,7 @@ public void commandRun() {
}
}
- private void print(String key, long number) {
+ private void print(String key, Object number) {
--- End diff --
It's better to override print with double number, which will be more
efficient, as we don't need to cast all the numbers to Object while printing
the metrics.
---
