[ https://issues.apache.org/jira/browse/ZOOKEEPER-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620709#comment-16620709 ]
Hadoop QA commented on ZOOKEEPER-2641: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//console This message is automatically generated. > AvgRequestLatency metric improves to be more accurate > ----------------------------------------------------- > > Key: ZOOKEEPER-2641 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2641 > Project: ZooKeeper > Issue Type: Improvement > Affects Versions: 3.4.7, 3.4.9 > Reporter: Allen Chan > Assignee: maoling > Priority: Minor > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > I posted a thread on the mailing list about finding AvgRequestLatency metric > to be 0 all the time. I believe this is a valuable metric because it is > useful to baseline performance of ZK and know when something is going wrong. > Another user (Arshad Mohammad) wrote up these notes. I am not a developer so > i do not have ability to patch this. Filing this so hopefully someone with > developer abilities can add this improvement. > "I find two reason whys AvgRequestLatency is almost all the time 0 > 1) Ping requests are counted the most: > AvgRequestLatency is calculated as > AvgRequestLatency=totalLatency/count > Ping requests come very often and complete very fast, these request add > nothing to totalLatency but add one to count. > 2) Wrong data type is chosen to store AvgRequestLatency: > AvgRequestLatency is calculated and store as the long value instead of > double vlaue. > In my opinion ZooKeeper code should be modified to improve this metrics > i) Ping request should be ignored while recording the statistics or at > least should be configurable whether to ignore or not. If ping request is > not counted even other metrics will be more meaningful. > ii) AvgRequestLatency should be of double type" -- This message was sent by Atlassian JIRA (v7.6.3#76005)