Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r221369391
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -303,6 +305,10 @@ public void parseProperties(Properties zkProp)
                     } else {
                         throw new ConfigException("Invalid option " + value + 
" for reconfigEnabled flag. Choose 'true' or 'false.'");
                     }
    +            } else if (key.equals("sslQuorum")){
    +                sslQuorum = Boolean.parseBoolean(value);
    +            } else if (key.equals("portUnification")){
    +                shouldUsePortUnification = Boolean.parseBoolean(value);
    --- End diff --
    
    I agree with @hanm - comment out these two lines, and add a comment:
    
    `// TODO: UnifiedServerSocket is currently buggy, will be fixed when 
@ivmaykov's PRs are merged. Disable port unification until then.`


---

Reply via email to