Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226849723
--- Diff: ivy.xml ---
@@ -59,9 +59,11 @@
<dependency org="org.apache.yetus" name="audience-annotations"
rev="${audience-annotations.version}"/>
- <dependency org="io.netty" name="netty" conf="default"
rev="${netty.version}">
- <artifact name="netty" type="jar" conf="default"/>
- </dependency>
+ <dependency org="io.netty" name="netty-common" conf="default"
rev="${netty.version}" />
--- End diff --
I forgot about this.
I think it is better to use netty-all because it bundles all of the native
artifacts.
In Bookkeeper for instance we have netty -all, but this is common practice
in many other projects.
---
