Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/673#discussion_r235060561
  
    --- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java 
---
    @@ -86,10 +86,16 @@
     public class ZooKeeperServer implements SessionExpirer, 
ServerStats.Provider {
         protected static final Logger LOG;
     
    +    public static final String GLOBAL_OUTSTANDING_LIMIT = 
"zookeeper.globalOutstandingLimit";
    +    protected static int globalOutstandingLimit = 1000;
    --- End diff --
    
    @lvfangmin Please don't mute Findbugs. I think the original implementation 
with the overridable getter was a lot neater. Sorry, I didn't have a chance to 
review this patch and catch it in time.


---

Reply via email to