eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244995163
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ########## @@ -18,6 +18,7 @@ package org.apache.zookeeper; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; Review comment: @anmolnar personally I like to use annotation because when you read the java file you see the problems. And I am usually using the configuration file for coarse grained control, like when there is some kind of check you don't want to consider at all or in many files ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
