arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248964112
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ########## @@ -238,18 +239,19 @@ public int getSslHandshakeTimeoutMillis() { return result; } + @SuppressWarnings("unchecked") public SSLContext createSSLContext(ZKConfig config) throws SSLContextException { - if (config.getProperty(sslClientContextProperty) != null) { - LOG.debug("Loading SSLContext from property '" + sslClientContextProperty + "'"); - String sslClientContextClass = config.getProperty(sslClientContextProperty); + if (config.getProperty(sslContextSupplierClassProperty) != null) { + LOG.debug("Loading SSLContext supplier from property '" + sslContextSupplierClassProperty + "'"); Review comment: Yep, no problem 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services