eolivelli edited a comment on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781#issuecomment-455822454 @jhuan31 no problem. This is the master JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-3092 This is my last email on this topic https://mail-archives.apache.org/mod_mbox/zookeeper-dev/201901.mbox/%3CCACcefgdVLQg4e5kFky7MjTfQn67%2BkT-2Kity8P%2B_ePtCm7pJUw%40mail.gmail.com%3E please subscribe to the dev list if you aren't already subscribed, this way it will be easier to discuss http://zookeeper.apache.org/lists.html I think that the main step is to refactor the ServerMetrics enum: - it should not be an *enum*, but a class with a field for each metric, each server will have only an instance of this class - each metric should be created from the main "MetricsProvider" object We can refactor Facebooks-contributed metrics internal facilities to a "Facebook Metrics Provider" for instance We are currently in the process of migrating from Ant to Maven so it will be easier to split the codebase in modules. You are going to contribute a big set of new metrics, and you and your collegues (at FB) are the only one which are running them in production so to me it makes sense that such refactoring will be driven by you. It is better to discuss on the mailing list about high level design decisions Thank you for this great features that you are contributing back to the community cc @lvfangmin
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
