anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456802034 Hi @eolivelli @nkalmar . I did another test today by rebasing this patch on latest master and running `mvn clean package -DskipTests` command. I looked at the following artifacts: **Source package tar.gz and zip in target folder** *We release this as the source package according to Apache standards (https://www.apache.org/legal/release-policy.html#source-packages)* Issues: - root level `pom.xml` file is missing and the project cannot be built, - recipes subprojects are missing, so even if I copy over the top-level pom.xml, the project cannot be built, - zookeeper-contrib project is missing: we don't want to include in the release? - mvn install is looking for `src/assembly/source-package.xml`, but it's missing - also looking for `.git` directory in zookeeper-server which is obviously missing, - overall, the user MUST be able to build it without any modifications, so this needs to be fixed. **Maven jars in target folders (sources, tests, main)** - main jar: `lib` folder and resource files, - tests.jar: `data` fodler and resource files, patch build / github scripts, - sources.jar: `lib` folder and resource files. There're 2 additional jar files created by the Ant process: `bin` and `javadoc` which I haven't found in the maven build.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
