athanatos commented on a change in pull request #787: ZOOKEEPER-3253: client
should not send requests with cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#discussion_r251145160
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -1510,6 +1511,11 @@ public void close() throws IOException {
* the server. Thus, getXid() must be public.
*/
synchronized public int getXid() {
+ // xid values of -4, -2, and -1 are special, see
SendThread.readResponse
Review comment:
I'm inclined to keep the patch minimal since grepping for those identifiers
wouldn't tell you where those packets get sent. Also, the numerical values are
useful to see here. I don't feel strongly about it though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
