eolivelli commented on a change in pull request #788: ZOOKEEPER-3256: Enable 
OWASP checks  to Maven build
URL: https://github.com/apache/zookeeper/pull/788#discussion_r251198383
 
 

 ##########
 File path: build.xml
 ##########
 @@ -1700,7 +1700,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
 
     <target name="owasp" depends="owasp-taskdef,ivy-retrieve" 
description="OWASP dependency check">
         <property name="owasp.out.dir" value="${test.java.build.dir}/owasp" />
-
+        <owasp:dependency-check-update 
xmlns:owasp="antlib:org.owasp.dependencycheck.anttasks" />
 
 Review comment:
   this is to make CI download patterns
   on CI we have a shared ant env and it seems not to download patterns 
automatically, the best is to force the download at every execution, it takes 
10 minutes but it is not a problem
   
   @phunt @anmolnar @hanm 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to