nkalmar commented on a change in pull request #828: Maven migration -
ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation
URL: https://github.com/apache/zookeeper/pull/828#discussion_r259648774
##########
File path: pom.xml
##########
@@ -660,26 +666,20 @@
</executions>
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-assembly-plugin</artifactId>
+ <groupId>net.nicoulaj.maven.plugins</groupId>
Review comment:
I will add some comments, thanks for bringing attention to this.
Checksum generation was moved to deploy plugin:
https://issues.apache.org/jira/browse/MINSTALL-143
Deploy plugin will only generate checksum for artifacts moved to repository.
The generated tarts will not be moved to the repository.
I did not find a way to do this from the standard maven plugins. Every
article / question / forum I found suggested to use Nicoulaj's plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
