phunt commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r264012939
########## File path: zookeeper-client/zookeeper-client-c/src/mt_adaptor.c ########## @@ -502,13 +502,13 @@ int32_t fetch_and_add(volatile int32_t* operand, int incr) } // make sure the static xid is initialized before any threads started -__attribute__((constructor)) int32_t get_xid() Review comment: why is this being removed? Granted this is from a looong time ago but this is considered MT code and the changelog particularly mentions > * get_xid() is not thread-safe (xid initialization race condition > in the multi-threaded mode). please remove this change from the patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
