[ https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813841#comment-16813841 ]
Hudson commented on ZOOKEEPER-3341: ----------------------------------- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate (andor: rev 6dc61adbe41c712fbce930e598b3556da54e0667) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > Remove Superfluous ByteBuffer Duplicate > --------------------------------------- > > Key: ZOOKEEPER-3341 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > {code:java|title=QuorumCnxManager.java} > byte[] msgArray = new byte[length]; > din.readFully(msgArray, 0, length); > ByteBuffer message = ByteBuffer.wrap(msgArray); > addToRecvQueue(new Message(message.duplicate(), sid)); > {code} > The {{message}} is being duplicated and the original is GC'ed. Just pass the > {{message}}; do not bother with making a duplicate. I think this is a > copy+paste bug. > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198 -- This message was sent by Atlassian JIRA (v7.6.3#76005)