brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091
Prometheus.io integration
URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334605
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1383,4 +1392,85 @@ public void setResponseCachingEnabled(boolean
isEnabled) {
public ResponseCache getReadResponseCache() {
return isResponseCachingEnabled ? readResponseCache : null;
}
+
+ protected void registerMetrics() {
+ MetricsContext rootContext = ServerMetrics
+ .getMetrics()
+ .getMetricsProvider()
+ .getRootContext();
+
+ final ZKDatabase zkdb = this.getZKDatabase();
+ final ServerStats stats = this.serverStats();
+
+ rootContext.registerGauge("avg_latency", stats::getAvgLatency);
+
+ rootContext.registerGauge("max_latency", stats::getMaxLatency);
+ rootContext.registerGauge("min_latency", stats::getMinLatency);
+
+ rootContext.registerGauge("packets_received",
stats::getPacketsReceived);
+ rootContext.registerGauge("packets_sent", stats::getPacketsSent);
+ rootContext.registerGauge("num_alive_connections",
stats::getNumAliveClientConnections);
+
+ rootContext.registerGauge("outstanding_requests",
stats::getOutstandingRequests);
+ rootContext.registerGauge("uptime", stats::getUptime);
Review comment:
process_start_time_seconds covers this for you already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
