anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492603934 @enixon Please double check your test code, it looks like this patch has introduced a flaky test: https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java10/563/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/521/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java11/422/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java11/423/ ... with the following error: ``` junit.framework.AssertionFailedError: too many snapshot files at org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLog(RestoreCommittedLogTest.java:119) at org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLogWithSnapSize(RestoreCommittedLogTest.java:67) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
