enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on 
log size
URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492804816
 
 
   @anmolnar It looks like the issue is FileTxnLog::getCurrentLogSize returns a 
multiple of a high number that is dependent on the machine running the test 
(the current thresholds work for my machine but playing with them starts to 
generate predictable error). With the low size thresholds in use in this test 
(e.g. less than 100 Kb), this leads to false positives in the "should snapshot" 
logic from the point of view of the test and it fails. 
   
   I can put up a patch that fixes this flakiness. What's the preferred 
procedure - open a new ticket or link to this ticket (ZK-3244)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to