hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816030
########## File path: conf/zoo_sample.cfg ########## @@ -6,6 +6,9 @@ initLimit=10 # The number of ticks that can pass between # sending a request and getting an acknowledgement syncLimit=5 +# The number of ticks that followers can take +# to connect to the leader after leader election +connectToLeaderLimit=5 Review comment: I think we probably want to rename this variable to something like `connectToLearnerMasterLimit`, or if we keep the current name, at least document that this will also impact the socket timeout between observer and learner master. This is unfortunate, so maybe we ultimately want to rename the method of `connectToLeader` to something like `connectToLearnerMaster`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
