Oh, bummer, I totally overlooked the version in the configs. We should maybe add some automated config checks to the build... :) This is not the first time an RC is cancelled because of the License files.
Norbert On Mon, Oct 7, 2019 at 3:13 PM Enrico Olivelli <[email protected]> wrote: > Andor, Norbert, > I have fixed the tag > https://github.com/apache/zookeeper/commits/release-3.5.6-rc3 > > Explanation of what happeed: > I had created the original tag as 'release-3.5.6rc3' (without the dash > sign) and when I re-created it I was on the master branch. > I apologize for the mistake. > > Binaries and source code were takes from this commit > > https://github.com/apache/zookeeper/commit/3433841cb8e8ed1e1a3ef65e6e986aae3de55677 > > But I am sorry as I have to CANCEL again this vote, as inside the "lib" > directory we still have Netty 4.1.29 license files instead of 4.1.42. > > so -1 from my side. > > I am sorry this is taking so long. > > Fortunately ZK codebase is in good shape, we are only cancelling votes for > third party dependencies and license files > > > Enrico > > > > > Il giorno lun 7 ott 2019 alle ore 14:27 Norbert Kalmar > <[email protected]> ha scritto: > > > +1 (non-binding) - once tag is fixed, which has the extra commit Andor > > mentioned. I verified that the RC does not contain the commit, so it's > just > > the tag. > > But the RC looks good to me! > > > > - unit tests pass > > - built and started ZK + run few commands from source tarball > > - checked bin tarball, license files, run ZK + few commands > > - signature OK. > > > > Thanks Enrico! > > > > > > On Mon, Oct 7, 2019 at 2:01 PM Andor Molnar <[email protected]> wrote: > > > > > +0 > > > > > > Release artifacts looks good to me: > > > - verified Release Notes, > > > - verified signatures, checksum, > > > - code built on Mac, Centos7 > > > - tests were successful, including C++ tests, > > > - verified 3-node cluster non-ssl, ssl mode with some basic cli > commands. > > > > > > However the git tag “release-3.5.6-rc3” does not seem to be right: it > > > points to commit: 768ac0fe which is a master-only commit with Jira id: > > > ZOOKEEPER-3532 (docker stuff). > > > > > > It should point to the latest commit on branch-3.5.6 instead: 3433841c > > > > > > (I’ll change my vote to +1 once the tag is fixed.) > > > > > > Andor > > > > > > > > > > > > > On 2019. Oct 5., at 18:34, Enrico Olivelli <[email protected]> > > wrote: > > > > > > > > This is a bugfix release candidate for 3.5.6. > > > > > > > > It fixes 29 issues, including upgrade of third party libraries, > > > > TTL Node APIs for C API, support for PCKS12 Keystores, upgrade of > > Netty 4 > > > > and better procedure for the upgrade of servers from 3.4 to 3.5. > > > > > > > > The full release notes is available at: > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12345243 > > > > > > > > *** Please download, test and vote by October 8nd 2019, 23:59 UTC+0. > > *** > > > > > > > > Source files: > > > > https://people.apache.org/~eolivelli/zookeeper-3.5.6-candidate-3 > > > > > > > > Maven staging repo: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1043/ > > > > > > > > The release candidate tag in git to be voted upon: release-3.5.6-rc3 > > > > https://github.com/apache/zookeeper/tree/release-3.5.6-rc3 > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > > > Should we release this candidate? > > > > > > > > Enrico Olivelli > > > > > > > > >
