+1 - Built from sources - Validated digest and signature for sources tar.gz - Verified that dependency from staging repo resolves - Checked release notes - Ran some local smoke tests
-Flavio > On 11 Oct 2019, at 08:45, Zili Chen <wander4...@gmail.com> wrote: > > +1 (non-binding) > > + verify source tarball contains no binary files > + verify binary tarball contains no source files > > + locally build by `mvn clean install -DskipTests -Pfull-build)` and verify > by `mvn verify`, tests pass > > + Verified basic zookeeper operation through Cli > > Best, > tison. > > > Mohammad arshad <mohammad.ars...@huawei.com> 于2019年10月11日周五 下午2:38写道： > >> +1 (non-binding) >> Verified checksums and signature >> Run UT on ubuntu 16.04 with jdk1.8.0_221 with non-root user. All 2554 UTs >> passed >> Verified basic zk operation through Cli >> Executed 4 letter word commands >> Verified admin server commands >> Ran rat >> All are OK :-) >> >> >> Thanks & Regards >> Mohammad Arshad >> >> -----Original Message----- >> From: sujith simon [mailto:sujithsimo...@gmail.com] >> Sent: Friday, October 11, 2019 11:32 AM >> To: dev@zookeeper.apache.org >> Subject: Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 4 >> >> +1 (non-binding) >> >> - Verified Checksum >> - Verified Signature >> - Verfied that tags are correct >> - Verified build, installed ZooKeeper and tested basic commands from >> source tarball >> - Installed ZooKeeper from bin tarball on a 3 node cluster and tested >> basic ZooKeeper commands >> - Verified that Unit tests are passing >> >> Thanks :) >> >> >> On Thu, Oct 10, 2019 at 2:53 PM Norbert Kalmar >> <nkal...@cloudera.com.invalid> >> wrote: >> >>> +1 (non-binding) >>> >>> - unit tests pass >>> - built and started ZK + run few commands from source tarball >>> - checked bin tarball, license files, run ZK + few commands >>> - signature OK. >>> - git tag OK :) >>> >>> Thanks Enrico! >>> >>> Norbert >>> >>> On Wed, Oct 9, 2019 at 10:45 PM Andor Molnar <an...@apache.org> wrote: >>> >>>> +1 >>>> >>>> Verified… >>>> >>>> - checksums, signature, >>>> - unit tests >>>> - 3-node cluster smoke tests. >>>> >>>> Andor >>>> >>>> >>>>> On 2019. Oct 9., at 22:40, Enrico Olivelli <eolive...@gmail.com> >>> wrote: >>>>> >>>>> Il mer 9 ott 2019, 21:14 Patrick Hunt <ph...@apache.org> ha scritto: >>>>> >>>>>> +1 checksums/sig validated. rat ran clean and I was able to build >>>>>> +and >>>>>> exercise the code just fine with java 8. >>>>>> >>>>>> Note dep check is failing again however: >>>>>> >>>>>> jackson-databind-2.9.10.jar >>>>>> (pkg:maven/com.fasterxml.jackson.core/jackson-databind@2.9.10, >>>>>> cpe:2.3:a:fasterxml:jackson:2.9.10:*:*:*:*:*:*:*, >>>>>> cpe:2.3:a:fasterxml:jackson-databind:2.9.10:*:*:*:*:*:*:*) : >>>>>> CVE-2019-16942, CVE-2019-16943 >>>>>> >>>>>> I looked at the issue and they seem very specific, given that and >>>>>> the status of databind these days I think we should get this one >>>>>> next time around vs re-re... spinning the rc. What do you think? >>>>>> >>>>> >>>>> Agreed. >>>>> And as we are doing a very limited use of Jackson we can look for >>>>> a replacement >>>>> >>>>> Enrico >>>>> >>>>>> >>>>>> Patrick >>>>>> >>>>>> >>>>>> On Tue, Oct 8, 2019 at 1:46 PM Enrico Olivelli >>>>>> <eolive...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> This is a bugfix release candidate for 3.5.6. >>>>>>> >>>>>>> It fixes 29 issues, including upgrade of third party libraries, >>>>>>> TTL Node APIs for C API, support for PCKS12 Keystores, upgrade >>>>>>> of >>>> Netty 4 >>>>>>> and better procedure for the upgrade of servers from 3.4 to 3.5. >>>>>>> >>>>>>> The full release notes is available at: >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310 >>> 801&version=12345243 >>>>>>> >>>>>>> *** Please download, test and vote by October 11th 2019, 23:59 >> UTC+0. >>>> *** >>>>>>> >>>>>>> Source files: >>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.5.6-candidate-4 >>>>>>> >>>>>>> Maven staging repo: >>>>>>> >>>>>> >>>> >>> https://repository.apache.org/content/repositories/orgapachezookeeper- >>> 1044 >>>>>>> >>>>>>> The release candidate tag in git to be voted upon: >>>>>>> release-3.5.6-rc4 >>>>>>> https://github.com/apache/zookeeper/tree/release-3.5.6-rc4 >>>>>>> >>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the >> release: >>>>>>> https://www.apache.org/dist/zookeeper/KEYS >>>>>>> >>>>>>> Should we release this candidate? >>>>>>> >>>>>>> Enrico Olivelli >>>> >>>> >>> >>
