Great! I created the following Jiras to create the missing Maven jobs:
Windows: https://issues.apache.org/jira/browse/ZOOKEEPER-3631 Java13: https://issues.apache.org/jira/browse/ZOOKEEPER-3632 Thanks, Andor > On 2019. Nov 24., at 22:43, Michael Han <[email protected]> wrote: > >>> ZooKeeper_UT_Stress (hanm’s private job - not sure if needed) > > I just deleted it. Thanks guys for taking care of the build system. > > On Fri, Nov 22, 2019 at 3:05 AM Enrico Olivelli <[email protected]> wrote: > >> Il giorno ven 22 nov 2019 alle ore 11:16 Andor Molnar <[email protected]> >> ha >> scritto: >> >>> Here’s another thing. (Maybe I should open a new thread) >>> >>> I’m disabled Ant-based trunk jobs in Jenkins and found the following >> which >>> doesn’t have Maven alternative: >>> >>> - ZooKeeper-trunk-java13 >>> >> >> I would keep this, in Maven version >> >> >>> - Zookeeper-trunk-single-thread >>> >> >> I think this is not really needed, it was created to the stability of the >> suite using single thread mode (IIRC) >> >> >>> - ZooKeeper-trunk-windows-cmake >>> >> >> Yes we need it >> >> >>> - ZooKeeper_UT_Stress (hanm’s private job - not sure if needed) >>> >> >> Leaving the word to Micheal H >> >> >> Thank you Andor for helping with this housekeeping work >> >> Enrico >> >> >> >>> >>> Would you please confirm? >>> I’ll open new Jira tickets to cover these and also another one for the >>> crash-not-reported issue. >>> >>> Thanks, >>> Andor >>> >>> >>> >>>> On 2019. Nov 22., at 7:17, Enrico Olivelli <[email protected]> >> wrote: >>>> >>>> Andor >>>> You are totally right. >>>> I will investigate today >>>> >>>> >>>> Enrico >>>> >>>> Il ven 22 nov 2019, 07:13 Andor Molnar <[email protected]> ha scritto: >>>> >>>>> Though the job is still running on master. This ran 13 hours ago: >>>>> >>>>> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-github-pr-build/4259/ >>>>> >>>>> But the result is not reported on the pull request. >>>>> The latest 2 Maven builds are reported as “Jenkins” and >> “JenkinsMaven”. >>>>> >>>>> Andor >>>>> >>>>> >>>>> >>>>>> On 2019. Nov 22., at 7:09, Andor Molnar <[email protected]> wrote: >>>>>> >>>>>> Hi Enrico, >>>>>> >>>>>> Looks like a previous Maven build has been reported as “Jenkins” on >>> this >>>>> patch: >>>>>> https://github.com/apache/zookeeper/pull/1147 >>>>>> >>>>>> So it’s not the Ant build which still running on master. >>>>>> >>>>>> Andor >>>>>> >>>>>> >>>>>> >>>>>>> On 2019. Nov 15., at 16:41, Andor Molnar <[email protected]> wrote: >>>>>>> >>>>>>> Yes we do. >>>>>>> >>>>>>> We just discussed on the PR that Maven surefire plugin cannot be >>>>> configured to report crashed tests as build errors. >>>>>>> As I highlighted although tests were crashed during the build >> process, >>>>> Maven still reports as a green build: >>>>>>> >>>>>>> >>>>> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/zookeeper-master-maven/521/ >>>>>>> >>>>>>> Andor >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> On 2019. Nov 15., at 16:01, Enrico Olivelli <[email protected]> >>>>> wrote: >>>>>>>> >>>>>>>> Il ven 15 nov 2019, 15:28 Andor Molnar <[email protected]> ha >>> scritto: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> I noticed that PR#1139 has been merged. As a consequence I have to >>>>>>>>> remove/disable all of the Ant-based build jobs in this Jenkis >>>>> dashboard: >>>>>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/ >>>>>>>>> >>>>>>>>> Which also means that we don’t have a build job which is able to >>> alert >>>>>>>>> when a test has crashed. >>>>>>>>> >>>>>>>> >>>>>>>> I can't follow you. >>>>>>>> We do have the maven jobs, don't we? >>>>>>>> >>>>>>>> Enrico >>>>>>>> >>>>>>>> >>>>>>>>> Is that okay? >>>>>>>>> >>>>>>>>> Andor >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 2019. Nov 15., at 11:06, Andor Molnar <[email protected]> >> wrote: >>>>>>>>>> >>>>>>>>>> Original patch: >>>>>>>>>> >>>>>>>>>> "ZOOKEEPER-3598: Fix potential data inconsistency issue due to >>>>>>>>>> >>>>>>>>>> has been reverted. >>>>>>>>>> >>>>>>>>>> Fangmin, my apologies for the inconvenience. >>>>>>>>>> Would you please create another PR with different solution or >> with >>>>>>>>> Enrico’s workaround? >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Andor >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2019. Nov 14., at 7:54, Andor Molnar <[email protected]> >> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi Enrico, >>>>>>>>>>> >>>>>>>>>>> +1 for the idea >>>>>>>>>>> I think the best would be to do this before we cut the first >>>>> version of >>>>>>>>> 3.6.0. >>>>>>>>>>> >>>>>>>>>>> Btw I noticed that the trunk build is completely broken since >>>>>>>>>>> >>>>>>>>> >>>>> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/769/ >>>>>>>>>>> >>>>>>>>>>> It’s failing on Java versions since we introduced those 2 >> commits. >>>>>>>>>>> But looks like the Maven build is still fine. >>>>>>>>>>> >>>>>>>>>>> Andor >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2019. Nov 11., at 13:36, Enrico Olivelli < >> [email protected] >>>> >>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi community, >>>>>>>>>>>> I have just sent a PR to drop ANT from main build (not from >>>>>>>>>>>> recipes/contrib) and keep only Maven build. >>>>>>>>>>>> We are already releasing 3.5 branch with Maven, this is only >> the >>>>> final >>>>>>>>> step >>>>>>>>>>>> of this long story. >>>>>>>>>>>> Once we have only Maven it will be super easy to refactor the >>>>> layout >>>>>>>>> of the >>>>>>>>>>>> codebase (separate common/client/metrics provider apis...). >>>>>>>>>>>> >>>>>>>>>>>> https://github.com/apache/zookeeper/pull/1139 >>>>>>>>>>>> >>>>>>>>>>>> I really would like to commit this patch before cutting 3.6. >>>>>>>>>>>> btw we are not going to add other big refactors before 3.6, so >> it >>>>> is >>>>>>>>> not a >>>>>>>>>>>> blocker for the release. >>>>>>>>>>>> >>>>>>>>>>>> Enjoy >>>>>>>>>>>> >>>>>>>>>>>> Enrico >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>> >>> >>
