Thanks Enrico for the check. I created a jira to fix the mentioned differences between source tarball and git: ZOOKEEPER-3727 (fix version 3.5.8)
Thanks everyone for the vote and tests. We have 3 binding +1. I will move forward to publish 3.5.7-rc2 as the 3.5.7 release. - Norbert On Fri, Feb 14, 2020 at 12:45 PM Enrico Olivelli <[email protected]> wrote: > +1 (binding) > > Verified checksums and signatures > Built from sources on MacOS using docker environment that emulates > linux (dev/docker directory). > > Run a few smoke tests on MacOs using JDK13 > > Tested the upgrade scenario from 3.4.14 (see > https://issues.apache.org/jira/browse/ZOOKEEPER-3644) using > snapshot.trust.empty=true (fix in 3.5.6 was partial and lead to data > loss) > > I have noticed that mvn checkstyle:check does not work due to the lack > of checkstyle.xml file. > the source tarball does not match perfectly the tag due to the > presence of some generated file, but it is the same as for 3.5.6, so > this is not blocker to me. > > Thank you Norbert for driving this release. Well done > > Enrico > > Il giorno mer 12 feb 2020 alle ore 21:29 Patrick Hunt > <[email protected]> ha scritto: > > > > +1 xsum/sig verify, rat ran clean, compiled from source and ran some > manual > > testing. > > > > Patrick > > > > On Mon, Feb 10, 2020 at 7:23 AM Andor Molnar <[email protected]> wrote: > > > > > +1 (binding) > > > > > > - release notes are OK, > > > - documentation looks good, > > > - verified signatures, checksum, > > > - Java & C unit tests passed, > > > - verified 3-node cluster with zk-latencies.py (create, get, delete, > > > setAcl, getAcl, watchers) > > > > > > Andor > > > > > > > > > > > > > On 2020. Feb 10., at 12:52, Norbert Kalmar <[email protected]> > wrote: > > > > > > > > This is the third bugfix release candidate for 3.5.7. It fixes 25 > issues, > > > > including third party CVE fixes, potential data loss and potential > split > > > > brain if some rare conditions exists. > > > > > > > > There are 4 additional patches compared to rc0 and rc1: > > > > - ZOOKEEPER-3453: missing 'SET' in zkCli on windows > > > > - ZOOKEEPER-3716: upgrade netty 4.1.42 to address CVE-2019-20444 > CVE-20… > > > > - ZOOKEEPER-3718: The tarball generated by assembly is missing some > files > > > > - ZOOKEEPER-3719: Fix C Client compilation issues > > > > > > > > The full release notes are available at: > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346098 > > > > > > > > *** Please download, test and vote by February 13th 2020, 23:59 > UTC+0. > > > *** > > > > > > > > Source files: > > > > https://people.apache.org/~nkalmar/zookeeper-3.5.7-candidate-2/ > > > > > > > > Maven staging repo: > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.7/ > > > > > > > > The release candidate tag in git to be voted upon: release-3.5.7-rc2 > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > > > Should we release this candidate? > > > > > > >
