I have merged Michael's patch. Running the release procedure right now
Stay tuned Enrico Il giorno ven 10 apr 2020 alle ore 20:17 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Thank you Micheal > > I will pick up the patch. > > > Enrico > > Il Ven 10 Apr 2020, 20:12 Michael Han <h...@apache.org> ha scritto: > >> would be good to get ZOOKEEPER-3793 in this release. Without >> ZOOKEEPER-3793 >> zk will not throttle requests at all, given RequestThrottler is disabled >> by >> default (and requires some understanding to configure it correctly). >> >> On Thu, Apr 9, 2020 at 10:04 PM Enrico Olivelli <eolive...@gmail.com> >> wrote: >> >> > Il Ven 10 Apr 2020, 04:35 Christopher <ctubb...@apache.org> ha scritto: >> > >> > > I don't anticipate any issues, but I can test Accumulo with the >> > > release candidate when it's ready. >> > > Do you already have the binary tarball built and uploaded somewhere? >> > > >> > >> > Not yet. >> > I will do it today or in the weekend. >> > Btw if you build from release-3.6.1 on Linux with JDK8 the results >> should >> > be the same. >> > You can use the docker env >> > dev/docker/run.sh >> > >> > I will use a Fedora 31 box directly >> > >> > Enrico >> > >> > >> > > On Thu, Apr 9, 2020 at 2:43 PM Enrico Olivelli <eolive...@gmail.com> >> > > wrote: >> > > > >> > > > Il Gio 9 Apr 2020, 20:33 Norbert Kalmar >> <nkal...@cloudera.com.invalid> >> > > ha >> > > > scritto: >> > > > >> > > > > Hi Enrico, >> > > > > >> > > > > Thanks for driving this! >> > > > > >> > > > > I managed to build HBase with ZooKeeper 3.5.7 having cherry-picked >> > the >> > > > > getRevision() patch. I know it's not 3.6.x, but I found the >> problem >> > > with >> > > > > this 3.5.7 and fixed it according to this on 3.6 as well. So it >> > should >> > > be >> > > > > fine now. >> > > > > >> > > > >> > > > Thank you >> > > > >> > > > Enrico >> > > > >> > > > > >> > > > > - Norbert >> > > > > >> > > > > On Thu, Apr 9, 2020 at 11:00 AM Enrico Olivelli < >> eolive...@gmail.com >> > > >> > > > > wrote: >> > > > > >> > > > > > Hi, >> > > > > > I am going to prepare a release candidate for ZooKeeper 3.6.1. >> > > > > > >> > > > > > There is no JIRA issue with fixVersion = 3.6.1 that is >> unresolved. >> > > > > > >> > > > > > I have tested a few projects that had compatibility issues and >> they >> > > are >> > > > > > resolved (like Apache BookKeeper and other non OS projects in my >> > > > > company). >> > > > > > >> > > > > > I remember that Norbert pointed a problem with HBase client, >> that >> > > uses >> > > > > > getRevision() method, it would be super great to have some >> feedback >> > > of >> > > > > > compatibility of HBase with 3.6.1 client. >> > > > > > >> > > > > > I have deployed the snapshots to snapshots.apache.org, this way >> > you >> > > can >> > > > > > easily test your project in CI, even on Travis. >> > > > > > >> > > > > > I have created the work branch for release >> > > > > > https://github.com/apache/zookeeper/tree/release-3.6.1 >> > > > > > >> > > > > > Please ping me if you have any questions or concerns or you >> need to >> > > add >> > > > > new >> > > > > > items. >> > > > > > >> > > > > > I will start the release procedure once I have self validated >> the >> > > status >> > > > > of >> > > > > > that branch >> > > > > > >> > > > > > Stay tuned >> > > > > > >> > > > > > Enrico >> > > > > > >> > > > > >> > > >> > >> >