I looked at it, and it seemed reasonable. My review isn't binding,
though. My understanding is that you still need another committer to
approve it.

On Fri, Apr 10, 2020 at 2:52 AM tison <wander4...@gmail.com> wrote:
>
> Hi ZK Devs,
>
> A few months ago I create a PR for gracefully handling null default
> watcher[1]. After some
> discussion it seems we reach a consensus that
>
> 1. Forbid require default watcher (boolean watcher=true) if default watcher
> is null.
> 2. Exclude null default watcher from materialize watches which cause NPE in
> ClientCnxn.EventThread#processEvent
>
> Though, it stalls for quite a bit and I'd like to throw it into mailing
> list and request for reviews.
>
> Feedback is appreciated!
>
> Best,
> tison.
>
> [1] https://github.com/apache/zookeeper/pull/1120

Reply via email to