+1 (binding) - checksums/signatures ok (imported new gpg key) - apache rat ok - compiled on Fedora 31 + jdk14 - run C tests on Fedora 31 - compiled and run Java tests on Mac with JDK14 - run a few smoke tests using the provided binaries on Mac with JDK8 and JDK14 - compared with apache-zookeeper-3.5.7 binary tarball, the packaging is the same
I have notices that we are not bundling LICENSE files for Jetty, Jackson, Javax Servlet API that are not Apache products. This is the same in 3.5.7 an in 3.6.1, so I do not consider it as a blocker, but we should improve it Thank you Mate for putting this together Enrico Il giorno gio 7 mag 2020 alle ore 17:14 Patrick Hunt <[email protected]> ha scritto: > +1. xsum/sig verified. rat ran clean. Compiled and ran various manual tests > successfully. > > Patrick > > On Wed, May 6, 2020 at 6:03 AM Andor Molnar <[email protected]> wrote: > > > +1 (binding) > > > > - release notes looks good, > > - documentation looks good, > > - licence files look good, > > - run java unit tests on Java 8 & 11, > > - run C unit tests on Ubuntu 19.10 > > - run rat, spotbugs, checkstyle checks > > - verified 5-node cluster with zk-latencies.py, zk-smoketest.py, > > - verified TTL nodes feature > > > > Nice rc0, thanks Mate! > > > > Andor > > > > > > > > > On 2020. May 5., at 13:33, Norbert Kalmar <[email protected] > > > > wrote: > > > > > > Great, thanks Máté! > > > > > > +1 (non-binding) > > > Did my usual build and testing, verified signature (new public key in > > > KEYS), compared src release with git repository, checked license files > - > > > all looks good to me. > > > I'm rooting for an RC0 release! :) > > > > > > Regards, > > > Norbert > > > > > > On Mon, May 4, 2020 at 6:22 PM Szalay-Bekő Máté < > > [email protected]> > > > wrote: > > > > > >> This is a release candidate for 3.5.8, a bugfix release > > >> introducing bugfixes and improvements including: > > >> - compatibility with applications built against earlier 3.5 client > > >> libraries (restored a few non public APIs) > > >> - CVE fixes (update Netty to 4.1.48.Final and Jackson-databind to > > 2.10.3) > > >> - Fix several ZooKeeper leader-election bugs > > >> - Make sources buildable with JDK14 > > >> > > >> The full release notes is available at: > > >> > > >> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346950 > > >> > > >> *** Please download, test and vote by May 10th 2020, 23:59 UTC+0. *** > > >> > > >> Source files: > > >> https://people.apache.org/~symat/zookeeper-3.5.8-rc0/ > > >> > > >> Maven staging repo: > > >> > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1059/ > > >> > > >> The release candidate tag in git to be voted upon: release-3.5.8-rc0 > > >> https://github.com/apache/zookeeper/tree/release-3.5.8-rc0 > > >> > > >> ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > >> https://www.apache.org/dist/zookeeper/KEYS > > >> > > >> The staging version of the website is: > > >> https://people.apache.org/~symat/zookeeper-3.5.8-rc0/webpage/ > > >> > > >> Should we release this candidate? > > >> > > >> Mate Szalay-Beko > > >> > > > > >
