Norbert I like this idea I have some experience with JaCoCo. For an OpenSource project like Zookeeper we should integrate it with services like CodeCov or Coveralls.io (I am using Coveralls for instance)
Such tool will be useful for requiring a quality gate on pull requests and in order to increase code coverage in general. Zookeeper codebase is quite simple and it will work well. My proposal is to enable it on pull requests and link with Coveralls.io (or other service) This way we will easily have a report about the impact of each patch to code coverage. Default reports are useful out of the box. No need to set Coveralls.io report as blocker for merging a patch. Enrico Il Lun 7 Set 2020, 22:29 Norbert Kalmar <nkal...@cloudera.com.invalid> ha scritto: > Hi all, > > Just a quick email to raise awareness to code coverage in ZK. > We've seen demand for it, also found an old ticket about it: ZOOKEEPER-2266 > I did a quick patch to integrate jacoco: > https://github.com/apache/zookeeper/pull/1451 > > My question is, do you think this is useful, something we should have in > ZK? > It's by default off (the code coverage report generation that is). > > I know it has it's... perils. (Like when we launch a whole zk server for a > test and that covers a lot of code). But it's still something I see demand > for, to have some kind of report about this. > > Regards, > Norbert >
