+1 (binding) - Verified checksums and signatures - Verified RAT and checkstyle on downloaded source tarball - Run a few smoke tests - Run tests on Mac + JDK8/14 - Run C Client tests on Fedora 32
a little nit about "zkServer.sh version" command, as it is not a regression I won't consider it a blocker https://issues.apache.org/jira/browse/ZOOKEEPER-3931 @Micheal I will fix the release notes during the update of the website, thanks for pointing out Enrico Il giorno mar 8 set 2020 alle ore 16:36 Enrico Olivelli <eolive...@gmail.com> ha scritto: > It looks like we need 1 more binding vote. > > Enrico > > Il giorno lun 7 set 2020 alle ore 22:57 Norbert Kalmar > <nkal...@cloudera.com.invalid> ha scritto: > >> Thanks Enrico, +1 (non-binding)from me. >> >> - Built the source, run tests >> - Run ZK and tried basic commands using zkCli >> - files check in tarball >> >> >> About website issue: generareted website can be fixed manually, we did >> this >> earlier, I don't think it's a blocker. >> Changelog, same, it should be fixed manually for the website >> >> @Tison: we released these modules last time, we can have a vote to not >> include it in the next release, but definitely not a blocker for this RC. >> But good point, we talked about excluding some (mainly contrib) modules. >> >> Regards, >> Norbert >> >> On Sun, Sep 6, 2020 at 5:10 AM tison <wander4...@gmail.com> wrote: >> >> > Besides, shall we release the following modules? >> > >> > - zookeeper-contrib-rest >> > - zookeeper-it >> > >> > Best, >> > tison. >> > >> > >> > tison <wander4...@gmail.com> 于2020年9月6日周日 上午10:57写道： >> > >> > > jump to >> > > >> > >> https://people.apache.org/~eolivelli/zookeeper-3.6.2-candidate-1/website/apidocs/zookeeper-server/index.html >> > > >> > > from sidebar "Developer>API Docs" returns 404, it is a testing >> > environment >> > > issue? >> > > >> > > Best, >> > > tison. >> > > >> > > >> > > Michael Han <h...@apache.org> 于2020年9月5日周六 上午5:55写道： >> > > >> > >> +1, with two minor issues: >> > >> >> > >> There is one unit test deterministically failing for me locally on >> mac: >> > >> MultipleAddressesTest.testGetValidAddressWithNotValid Expected >> > exception: >> > >> java.net.NoRouteToHostException >> > >> >> > >> Also missing a couple of items in release notes: ZOOKEEPER-3794, >> > >> ZOOKEEPER-3797, ZOOKEEPER-3813 >> > >> >> > >> Neither is blocker IMO but would be nice to update the release note >> > >> considering one of the missing items is CVE related fix. >> > >> >> > >> On Fri, Sep 4, 2020 at 1:04 PM Patrick Hunt <ph...@apache.org> >> wrote: >> > >> >> > >> > +1. xsum/sig validate. RAT ran clean. Was able to build and do >> manual >> > >> > testing with various ensemble sizes successfully. lgtm. >> > >> > >> > >> > Patrick >> > >> > >> > >> > On Fri, Sep 4, 2020 at 6:01 AM Enrico Olivelli < >> eolive...@gmail.com> >> > >> > wrote: >> > >> > >> > >> > > This is a release candidate for 3.6.2. >> > >> > > >> > >> > > It is a minor release and it fixes a few critical issues and >> brings >> > a >> > >> few >> > >> > > dependencies upgrades. >> > >> > > >> > >> > > The full release notes is available at: >> > >> > > >> > >> > > >> > >> > >> > >> >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12347809 >> > >> > > >> > >> > > *** Please download, test and vote by September 7th 2020, 23:59 >> > UTC+0. >> > >> > *** >> > >> > > >> > >> > > Source files: >> > >> > > >> https://people.apache.org/~eolivelli/zookeeper-3.6.2-candidate-1/ >> > >> > > >> > >> > > Maven staging repo: >> > >> > > >> > >> > >> > >> >> > >> https://repository.apache.org/content/repositories/orgapachezookeeper-1061/ >> > >> > > >> > >> > > The release candidate tag in git to be voted upon: >> release-3.6.2-1 >> > >> > > https://github.com/apache/zookeeper/tree/release-3.6.2-1 >> > >> > > >> > >> > > ZooKeeper's KEYS file containing PGP keys we use to sign the >> > release: >> > >> > > https://www.apache.org/dist/zookeeper/KEYS >> > >> > > >> > >> > > The staging version of the website is: >> > >> > > >> > >> > >> > >> >> > >> https://people.apache.org/~eolivelli/zookeeper-3.6.2-candidate-1/website/ >> > >> > > >> > >> > > Should we release this candidate? >> > >> > > Enrico Olivelli >> > >> > > >> > >> > >> > >> >> > > >> > >> >
