zengchao created ZOOKEEPER-4001:
-----------------------------------
Summary: AuditHelper.addAuditLog(...) more readable
Key: ZOOKEEPER-4001
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4001
Project: ZooKeeper
Issue Type: Improvement
Components: server
Reporter: zengchao
{code:java}
if (failedTxn) {
CreateRequest createRequest = new CreateRequest();
deserialize(request, createRequest);
path = createRequest.getPath();
createMode =
getCreateMode(createRequest);
} else {
createMode = getCreateMode(request);
}
{code}
may modified to
{code:java}
CreateRequest createRequest = new CreateRequest();
deserialize(request, createRequest);
createMode = getCreateMode(createRequest);
if (failedTxn) {
path = createRequest.getPath();
}
{code}
the getCreateMode(request) is this
{code:java}
private static String getCreateMode(Request request) throws IOException,
KeeperException {
CreateRequest createRequest = new CreateRequest();
deserialize(request, createRequest);
return getCreateMode(createRequest);
}
{code}
is this change more readable?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
