I am validating the release I have this test that is consistently failing on the c-client
[exec] /Users/enrico.olivelli/Downloads/zk359/apache-zookeeper-3.5.9/zookeeper-client/zookeeper-client-c/tests/TestClient.cc:789: Assertion: equality assertion failed [Expected: 0, Actual : -4] Do you think it is a blocker for the release ? I am on MacOs + docker env (dev/docker/run.sh) Enrico Il giorno gio 7 gen 2021 alle ore 10:46 Szalay-Bekő Máté < szalay.beko.m...@gmail.com> ha scritto: > +1 (non-binding) > > - I built the source code (-Pfull-build) on Ubuntu 18.04 using OpenJDK > 8u265 and maven 3.6.3. > - all the unit tests passed eventually (both Java and C-client). > - I also built zkpython > - checkstyle and spotbugs passed > - apache-rat passed > - owasp (CVE check) passed > - I executed a quick rolling-upgrade test from 3.5.9 to 3.6.2. (using > https://github.com/symat/zk-rolling-upgrade-test) > > The only thing I found was 4 unit tests, failed first (when I executed all > tests in docker) but succeeded second time running them on my mac: > - QuorumPeerMainTest -> testLeaderOutOfView > - ReconfigExceptionTest -> testReconfigDisabled > - NIOServerCnxnFactoryTest -> testStartupWithoutStart_SocketAlreadyBound > - NIOServerCnxnFactoryTest -> testStartupWithStart_SocketAlreadyBound > > Thanks, > Mate > > On Wed, Jan 6, 2021 at 9:10 PM Norbert Kalmar <nkal...@apache.org> wrote: > > > This is a bugfix release candidate for 3.5.9. It contains 25 fixes, > > including CVE fixes. > > (Note: rc1 had a third party CVE which was only noticed during the last > > check of the release, so it never made it for vote) > > > > The full release notes is available at: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12348201 > > > > *** Please download, test and vote by January 11th 2020, 23:59 UTC+0. *** > > > > Source files: > > https://people.apache.org/~nkalmar/zookeeper-3.5.9-candidate-2/ > > > > Maven staging repo: > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.9/ > > > > The release candidate tag in git to be voted upon: release-3.5.9-rc2 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/zookeeper/KEYS > > > > Should we release this candidate? > > > > - Norbert > > >
