I have created the PR(https://github.com/apache/zookeeper/pull/1610) to add the committer checklist to commit script to avoid The Accident Case like: PR-1597. Please review it and provide more checklists if I have not covered.
----- Original Message ----- From: "Justin Ling Mao" <maoling199210...@sina.com> To: "dev" <dev@zookeeper.apache.org> Cc: "andor" <an...@apache.org> Subject: Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build Date: 2021-02-10 17:26 Haha, it scared me. Let me go through this accident. The root cause is: I'm over-confident, frivolous and hasty. I flatter myself that it's just a typo and committing it could not have anything bad happens. And I also don't give this PR a buffer time for other people's review. Accident is bad, but it's much more terrible if we can not reflect on it and think about how to avoid it next time. For remedy: I will add a new section: Commit Accident Case Study in [1] for the successor’s learning (Can anyone give me the permission to edit that wiki)? I will sum up our commit rules and the checklists before committing one patch, and do some works to use the Github CI and commit script to protect/check these constraint. For punishment: I will frozen/forbid my committership permission for three months(02-10 ~ 05-10). During this period, I must not commit anything. I wish I could reflect on my fault and have a better understanding on the wording: "With great power comes great responsibility" Reference:[1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute ----- Original Message ----- From: Andor Molnar <an...@apache.org> To: maoling199210...@sina.com Cc: dev <dev@zookeeper.apache.org> Subject: Re: Commit 4faf507 broke the build Date: 2021-02-10 00:26 I’m sorry Justin. There’s no excuse for a mistake like this. We should not show mercy for anybody, otherwise it would erode the trust in our community. Your committership is now revoked. Just kidding. Don’t worry at all. ;-) I reverted the patch, so now please create a new PR with all the required changes included. Also I second Enrico’s comment: if CI is in bad shape, we should fix it. Regards, Andor > On 2021. Feb 9., at 13:45, Justin Ling Mao <maoling199210...@sina.com> wrote: > > Oops, it's my blame. I'm very sorry for my mistakes. Since these days the CI > is in disorder and it's a typo, so I'm not waiting for CI check and forgot > that an UT has covered this change although I wrote these related codes. It's > all my mistake and I will summarize our submission process and this accident. > I will write another letter to discuss the commit rules and how to improve > our code review throughput > > > ----- Original Message ----- > From: Andor Molnar <an...@apache.org> > To: DevZooKeeper <dev@zookeeper.apache.org> > Subject: Commit 4faf507 broke the build > Date: 2021-02-09 19:43 > > Hi, > I noticed that the latest commit 4faf507 ZOOKEEPER-4007: A typo in the > ZKUtil#validateFileInput method broke the build, because the unit test has > not been amended. > I reverted the commit to fix the build. Please create new PR with a proper > patch. > Has the committer verified that the build is green before submitting it? > Andor
