+1 (non-binding) - Built source (including running tests) - Run and tested with basic commands from built source and also from bin tarball - Checked files included in tarballs
Minor side note: I had 2 failed tests on MacOS (ReadOnlyModeTest and RequestPathMetricsCollectorTest), after re-running them they passed. Thanks Damien, great work with the release! - Norbert On Fri, Mar 19, 2021 at 12:06 PM Szalay-Bekő Máté < szalay.beko.m...@gmail.com> wrote: > +1 (non-binding) > > Congrats Damien, nice job! > And also the tests got definitely much more stable! > (I had a single test that failed on my dockerized > linux: RequestPathMetricsCollectorTest - but this one was successfully > executed on my mac host, so possible it is only related to my docker > environment) > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK > 11.0.10 and maven 3.6.0. > - all the unit tests passed (both Java and C-client). > - I also built and executed unit tests for zkpython > - checkstyle and spotbugs passed > - apache-rat passed > - owasp (CVE check) passed > - fatjar built > - I also executed some quick rolling-upgrade tests from 3.5.9 to 3.7.0 and > also from 3.6.2 to 3.7.0 (using > https://github.com/symat/zk-rolling-upgrade-test) > > One minor website related issue: the tab on the top of the website page ( > > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/index.html > ) > still says "ZooKeeper 3.6 Documentation" > > Kind regards, > Mate > > On Wed, Mar 17, 2021 at 12:06 PM Damien Diederen <ddiede...@apache.org> > wrote: > > > > > Greetings, all! > > > > After a long delay, here is a third release candidate for ZooKeeper > 3.7.0. > > > > Compared to RC1, it contains... quite a few changes. It notably fixes > > the quota feature for multi transactions, repairs the test suite on > > macOS (Catalina), makes a few tests less flaky, and avoids a CVE. > > > > The complete set of changes can be obtained with the Git range > > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at: > > > > > > > https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2 > > > > I cannot say that I find the state of the test suite satisfactory, but > > the failures which are often observed are due to timing and/or TCP/IP > > port assignment issues, and repeated runs are "sufficient" to clear > > them. > > > > I was hoping to contribute more on that front, but have been unable so > > far, and don't want to keep the 3.7 branch hostage—so here is a timid > > RC2. > > > > > > ZooKeeper 3.7.0 introduces a number of new features, notably: > > > > * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874); > > > > * Quota enforcement (ZOOKEEPER-3301); > > > > * Host name canonicalization in quorum SASL authentication > > (ZOOKEEPER-4030); > > > > * Support for BCFKS key/trust store format (ZOOKEEPER-3950); > > > > * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561); > > > > * A "whoami" API and CLI command (ZOOKEEPER-3969); > > > > * The possibility of disabling digest authentication (ZOOKEEPER-3979); > > > > * Multiple SASL "superUsers" (ZOOKEEPER-3959); > > > > * Fast-tracking of throttled requests (ZOOKEEPER-3683); > > > > * Additional security metrics (ZOOKEEPER-3978); > > > > * SASL support in the C and Perl clients (ZOOKEEPER-1112, > > ZOOKEEPER-3714); > > > > * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427); > > > > * Notes on how to benchmark ZooKeeper with the YCSB tool > > (ZOOKEEPER-3264). > > > > > > The release notes are available here: > > > > > > > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617 > > > > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. *** > > > > Source files: > > > > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/ > > > > Maven staging repo: > > > > > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1067/ > > > > The release candidate tag in git to be voted upon: release-3.7.0-2 > > > > https://github.com/apache/zookeeper/tree/release-3.7.0-2 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/zookeeper/KEYS > > > > The staging version of the website is: > > > > > > > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/ > > > > > > Should we release this candidate? > > > > > > Damien Diederen > > >
